fix(activesync): refuse Draft Modify append-as-new for stale UIDs#201
Open
TDannhauer wants to merge 2 commits into
Open
fix(activesync): refuse Draft Modify append-as-new for stale UIDs#201TDannhauer wants to merge 2 commits into
TDannhauer wants to merge 2 commits into
Conversation
When an EAS 16 Drafts Modify references an IMAP UID that is already gone, do not treat it as a new draft append. Retries after a lost Sync response would otherwise grow the Drafts folder unbounded. Defense in depth for horde/ActiveSync#85 (idempotent importer short-circuit).
ralflang
requested changes
Jul 18, 2026
| @@ -1,4 +1,14 @@ | |||
| --- | |||
| 3.2.1: | |||
Member
There was a problem hiding this comment.
Don't to that - this is the release tool's job. You also create a mess as soon as another PR is released faster.
Contributor
Author
There was a problem hiding this comment.
good point, i'll instruct my agents.md
| $driver->setProtocolVersion(Horde_ActiveSync::VERSION_SIXTEEN); | ||
|
|
||
| $userProp = new \ReflectionProperty( | ||
| \Horde_ActiveSync_Driver_Base::class, |
Drop the hand-edited changelog entry (release tool owns it) and use import statements in the unit test instead of inline FQCNs.
Contributor
Author
|
Addressed the review notes:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Modifywhen the client ServerId (IMAP UID) is already missing: do not append a new draftsetDraftMessageso stale UIDs fail fast and attachment carry-over order stays correctMotivation
Defense in depth for horde/ActiveSync#85. The ActiveSync importer short-circuits retries when the prior apply was recorded; if that map write never landed, the previous Core behaviour (“stale UID → treat as new”) could still append unbounded copies on retry.
Changes
Horde_Core_ActiveSync_Driver::changeMessageDrafts branch: missing Modify UID → log notice, returnfalseDriverDraftModifyStaleUidTestTest plan
DriverDraftModifyStaleUidTest